Prevent passed ann_file from silently failing to load
#2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation Update repo information and URLs in README. ## Modification ## BC-breaking (Optional) ## Use cases (Optional) --------- Co-authored-by: CSH <[email protected]>
|
|
csatsurnh
reviewed
May 5, 2023
csatsurnh
approved these changes
May 8, 2023
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
…en-mmlab#2966) ## Motivation While customizing the number of samples using `ann_file` for Cityscapes, I noticed that when the `ann_file` name is incorrect, it will silently resort to loading the dataset from the directory. I think when the user intends to load using `ann_file`, it should not silently fail, but give some sort of error message or warning. ## Modification I added assertion to check whether the `ann_file` exists instead of silently resorting to loading from the directory. Since `ann_file` is set to `''` by default and joined with `self.data_root`, I used `osp.isdir` to first check if `self.ann_dir` is a directory or text file. ## BC-breaking (Optional) Not that I am aware of. ## Use cases (Optional) If this PR introduces a new feature, it is better to list some use cases here, and update the documentation. --------- Co-authored-by: 谢昕辰 <[email protected]> Co-authored-by: CSH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
While customizing the number of samples using
ann_filefor Cityscapes, I noticed that when theann_filename is incorrect, it will silently resort to loading the dataset from the directory.I think when the user intends to load using
ann_file, it should not silently fail, but give some sort of error message or warning.Modification
Please briefly describe what modification is made in this PR.
I added assertion to check whether the
ann_fileexists instead of silently resorting to loading from the directory.Since
ann_fileis set to''by default and joined withself.data_root, I usedosp.isdirto first check ifself.ann_diris a directory or text file.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Not that I am aware of.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist