Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast-SCNN implemented #58

Merged
merged 66 commits into from
Aug 18, 2020
Merged

Fast-SCNN implemented #58

merged 66 commits into from
Aug 18, 2020

Conversation

johnzja
Copy link
Contributor

@johnzja johnzja commented Aug 9, 2020

69.1% mIoU achieved, compared with 68% according to the original paper. Learning rate of 0.12 is suggested after multiple experimental trainings. However, three failures occurs when running pytest (failures are irrelevant with fast-scnn itself).

johnzja and others added 21 commits July 31, 2020 14:16
init commit: fast_scnn
6435e3e
247917iters
a5f1095
4x8_80k
06db844
configs placed in configs_unify. 4x8_80k exp.running.
9f236f3
@johnzja
mmseg/utils/collect_env.py modified to support Windows
e059136
@johnzja
Merge branch 'add_fast_scnn' of github.com:johnzja/mmsegmentation int…
2e43bae 
…o add_fast_scnn

On sensetime servers, I modified the config files.
On my PC, I modified collect_env.py.
Now I'm going to merge these two modifications.
@johnzja
study on lr
2b1f359
@johnzja
bug in configs_unify/***/cityscapes.py fixed.
dc6e781
@johnzja
lr0.08_100k
2bf70c5
@johnzja
lr_power changed to 1.2
e7f6b9e
@johnzja
log_config by_epoch set to False.
795fb20
@johnzja
lr1.2
d3a5342
@johnzja
doc strings added
2c77085
@johnzja
add fast_scnn backbone test
c16940c
@johnzja
80k 0.08,0.12
3d4db48
@johnzja
add 450k
8df067e
@johnzja
fast_scnn test: fix BN bug.
54ae2ee
@johnzja
Add different config files into configs/
dce6ec4
@johnzja
.gitignore recovered.
0dd1ae5
@johnzja
configs_unify del
94913d1
@johnzja
.gitignore recovered.
4102ed3
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

xvjiarui
xvjiarui reviewed Aug 9, 2020
View reviewed changes
mmseg/utils/collect_env.py Outdated Show resolved Hide resolved
xvjiarui
xvjiarui reviewed Aug 9, 2020
View reviewed changes
mmseg/models/backbones/fast_scnn.py Outdated


class FeatureFusionModule(nn.Module):
"""Feature fusion module."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may use standard doc string here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved.

@xvjiarui xvjiarui requested a review from hellock August 14, 2020 05:57
@johnzja johnzja requested a review from xvjiarui August 14, 2020 06:33
hellock
hellock reviewed Aug 14, 2020
View reviewed changes
configs/fastscnn/README.md
biburl = {https://dblp.org/rec/journals/corr/abs-1902-04502.bib},
bibsource = {dblp computer science bibliography, https://dblp.org}
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

@article{poudel2019fast,
  title={Fast-scnn: Fast semantic segmentation network},
  author={Poudel, Rudra PK and Liwicki, Stephan and Cipolla, Roberto},
  journal={arXiv preprint arXiv:1902.04502},
  year={2019}
}

@johnzja
Copy link
Contributor Author

johnzja commented Aug 16, 2020

Can we merge now?

@hellock
Copy link
Member

hellock commented Aug 17, 2020

There are conflicts with the master branch.

@johnzja
Merge branch 'master' of https:/open-mmlab/mmsegmentation …
3cbfbf6 
…into open-mmlab-master

# Conflicts:
#	docs/model_zoo.md
#	mmseg/models/backbones/__init__.py
#	tests/test_models/test_backbone.py
@johnzja
test_inverted_residual module corrected.
89dcce4
@johnzja
Copy link
Contributor Author

johnzja commented Aug 17, 2020

Now the master branch is correct.

@johnzja johnzja requested a review from hellock August 18, 2020 00:47
hellock
hellock reviewed Aug 18, 2020
View reviewed changes
tests/test_ops/test_inverted_residual_module.py Outdated
@@ -0,0 +1,40 @@
import pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since InvertedResidual is moved to utils, the test case should also be moved accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved.

@johnzja johnzja requested a review from hellock August 18, 2020 02:42
@johnzja
Copy link
Contributor Author

johnzja commented Aug 18, 2020

Can we merge now?

@hellock hellock merged commit c1f46a6 into open-mmlab:master Aug 18, 2020
johnzja added a commit to johnzja/mmsegmentation that referenced this pull request Aug 19, 2020
@johnzja @xvjiarui
Fast-SCNN implemented (open-mmlab#58) (#3)
bd2a875 
Co-authored-by: Jerry Jiarui XU <[email protected]>
johnzja added a commit to johnzja/mmsegmentation that referenced this pull request Aug 19, 2020
@johnzja
Merge pull request #4 from open-mmlab/master
ca08bfc 
Fast-SCNN implemented (open-mmlab#58)
johnzja added a commit to johnzja/mmsegmentation that referenced this pull request Aug 19, 2020
@johnzja @xvjiarui
Fast-SCNN implemented (open-mmlab#58)
acfe2d0 
* init commit: fast_scnn

* 247917iters

* 4x8_80k

* configs placed in configs_unify.  4x8_80k exp.running.

* mmseg/utils/collect_env.py modified to support Windows

* study on lr

* bug in configs_unify/***/cityscapes.py fixed.

* lr0.08_100k

* lr_power changed to 1.2

* log_config by_epoch set to False.

* lr1.2

* doc strings added

* add fast_scnn backbone  test

* 80k 0.08,0.12

* add 450k

* fast_scnn test: fix BN bug.

* Add different config files into configs/

* .gitignore recovered.

* configs_unify del

* .gitignore recovered.

* delete sub-optimal config files of fast-scnn

* Code style improved.

* add docstrings to component modules of fast-scnn

* relevant files modified according to Jerry's instructions

* relevant files modified according to Jerry's instructions

* lint problems fixed.

* fast_scnn config extremely simplified.

* InvertedResidual

* fixed padding problems

* add unit test for inverted_residual

* add unit test for inverted_residual: debug 0

* add unit test for inverted_residual: debug 1

* add unit test for inverted_residual: debug 2

* add unit test for inverted_residual: debug 3

* add unit test for sep_fcn_head: debug 0

* add unit test for sep_fcn_head: debug 1

* add unit test for sep_fcn_head: debug 2

* add unit test for sep_fcn_head: debug 3

* add unit test for sep_fcn_head: debug 4

* add unit test for sep_fcn_head: debug 5

* FastSCNN type(dwchannels) changed to tuple.

* t changed to expand_ratio.

* Spaces fixed.

* Update mmseg/models/backbones/fast_scnn.py

Co-authored-by: Jerry Jiarui XU <[email protected]>

* Update mmseg/models/decode_heads/sep_fcn_head.py

Co-authored-by: Jerry Jiarui XU <[email protected]>

* Update mmseg/models/decode_heads/sep_fcn_head.py

Co-authored-by: Jerry Jiarui XU <[email protected]>

* Docstrings fixed.

* Docstrings fixed.

* Inverted Residual kept coherent with mmcl.

* Inverted Residual kept coherent with mmcl. Debug 0

* _make_layer parameters renamed.

* final commit

* Arg scale_factor deleted.

* Expand_ratio docstrings updated.

* final commit

* Readme for Fast-SCNN added.

* model-zoo.md modified.

* fast_scnn README updated.

* Move InvertedResidual module into mmseg/utils.

* test_inverted_residual module corrected.

* test_inverted_residual.py moved.

* encoder_decoder modified to avoid bugs when running PSPNet.
getting_started.md bug fixed.

* Revert "encoder_decoder modified to avoid bugs when running PSPNet. "

This reverts commit dd0aadf

Co-authored-by: Jerry Jiarui XU <[email protected]>
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
@johnzja @xvjiarui
Fast-SCNN implemented (open-mmlab#58)
f6b9da5 
* init commit: fast_scnn

* 247917iters

* 4x8_80k

* configs placed in configs_unify.  4x8_80k exp.running.

* mmseg/utils/collect_env.py modified to support Windows

* study on lr

* bug in configs_unify/***/cityscapes.py fixed.

* lr0.08_100k

* lr_power changed to 1.2

* log_config by_epoch set to False.

* lr1.2

* doc strings added

* add fast_scnn backbone  test

* 80k 0.08,0.12

* add 450k

* fast_scnn test: fix BN bug.

* Add different config files into configs/

* .gitignore recovered.

* configs_unify del

* .gitignore recovered.

* delete sub-optimal config files of fast-scnn

* Code style improved.

* add docstrings to component modules of fast-scnn

* relevant files modified according to Jerry's instructions

* relevant files modified according to Jerry's instructions

* lint problems fixed.

* fast_scnn config extremely simplified.

* InvertedResidual

* fixed padding problems

* add unit test for inverted_residual

* add unit test for inverted_residual: debug 0

* add unit test for inverted_residual: debug 1

* add unit test for inverted_residual: debug 2

* add unit test for inverted_residual: debug 3

* add unit test for sep_fcn_head: debug 0

* add unit test for sep_fcn_head: debug 1

* add unit test for sep_fcn_head: debug 2

* add unit test for sep_fcn_head: debug 3

* add unit test for sep_fcn_head: debug 4

* add unit test for sep_fcn_head: debug 5

* FastSCNN type(dwchannels) changed to tuple.

* t changed to expand_ratio.

* Spaces fixed.

* Update mmseg/models/backbones/fast_scnn.py

Co-authored-by: Jerry Jiarui XU <[email protected]>

* Update mmseg/models/decode_heads/sep_fcn_head.py

Co-authored-by: Jerry Jiarui XU <[email protected]>

* Update mmseg/models/decode_heads/sep_fcn_head.py

Co-authored-by: Jerry Jiarui XU <[email protected]>

* Docstrings fixed.

* Docstrings fixed.

* Inverted Residual kept coherent with mmcl.

* Inverted Residual kept coherent with mmcl. Debug 0

* _make_layer parameters renamed.

* final commit

* Arg scale_factor deleted.

* Expand_ratio docstrings updated.

* final commit

* Readme for Fast-SCNN added.

* model-zoo.md modified.

* fast_scnn README updated.

* Move InvertedResidual module into mmseg/utils.

* test_inverted_residual module corrected.

* test_inverted_residual.py moved.

* encoder_decoder modified to avoid bugs when running PSPNet.
getting_started.md bug fixed.

* Revert "encoder_decoder modified to avoid bugs when running PSPNet. "

This reverts commit dd0aadf

Co-authored-by: Jerry Jiarui XU <[email protected]>
@dongbo811 dongbo811 mentioned this pull request Mar 28, 2022
Closed
@OpenMMLab-Assistant-007
Copy link

Hi!
@johnzja
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
@dreamerlin
Data preparation update (open-mmlab#58)
27444cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xvjiarui xvjiarui Awaiting requested review from xvjiarui

@hellock hellock Awaiting requested review from hellock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnzja @CLAassistant @xvjiarui @hellock @OpenMMLab-Assistant-007