Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixMIM #721

Merged
merged 17 commits into from
Mar 23, 2023
Merged

PixMIM #721

merged 17 commits into from
Mar 23, 2023

Conversation

YuanLiuuuuuu
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@YuanLiuuuuuu
Copy link
Collaborator Author

image

@YuanLiuuuuuu YuanLiuuuuuu changed the title Pixmim PixMIM Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.52 🎉

Comparison is base (447f4bb) 80.21% compared to head (74b40c9) 80.73%.

❗ Current head 74b40c9 differs from pull request most recent head 08227b7. Consider uploading reports for the commit 08227b7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #721      +/-   ##
===========================================
+ Coverage    80.21%   80.73%   +0.52%     
===========================================
  Files          141      144       +3     
  Lines         5129     5207      +78     
  Branches       687      693       +6     
===========================================
+ Hits          4114     4204      +90     
+ Misses         872      861      -11     
+ Partials       143      142       -1     
Flag Coverage Δ
unittests 80.73% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/datasets/transforms/__init__.py 100.00% <100.00%> (ø)
mmselfsup/datasets/transforms/pytorch_transform.py 100.00% <100.00%> (ø)
mmselfsup/models/algorithms/__init__.py 100.00% <100.00%> (ø)
mmselfsup/models/algorithms/pixmim.py 100.00% <100.00%> (ø)
mmselfsup/models/target_generators/__init__.py 100.00% <100.00%> (ø)
...sup/models/target_generators/low_freq_generator.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

configs/selfsup/pixmim/README.md Outdated Show resolved Hide resolved
configs/selfsup/pixmim/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fangyixiao18 fangyixiao18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanLiuuuuuu YuanLiuuuuuu merged commit 448b4fa into open-mmlab:dev-1.x Mar 23, 2023
@YuanLiuuuuuu YuanLiuuuuuu deleted the pixmim branch March 23, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants