golang: 1.20.7 -> 1.21 #6189
Merged
golang: 1.20.7 -> 1.21 #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😆 great |
I guess that's you |
srenatus
force-pushed
the
sr/bump/golang-1.21
branch
from
dde95e9
to
df7b02d
Compare
Signed-off-by: Stephan Renatus <[email protected]>
What was correct for 1.20 is correct for 1.21, so I've flipped the exception logic. Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/bump/golang-1.21
branch
from
df7b02d
to
65bb73a
Compare
johanfylling
approved these changes
Aug 29, 2023
| default: | ||
| return false | ||
| } | ||
| return true |
There was a problem hiding this comment.
Fallthrough not being the default in go still requires me to think twice 😅.
There was a problem hiding this comment.
sorry my slightly obnoxious way to avoid || and && 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore: Update Golang used for building OPA. Release notes