Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[awsemf-exporter] Enable Resource_Attributes_To_Telemetry_Conversion option #1551

Closed
hossain-rayhan opened this issue Nov 11, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@hossain-rayhan
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Recently a PR 2060 was merged in the core opentelemetry-collector repo for converting resource attributes to metric labels. This was added as a utility option in the exporterhelper module so that any exporter can easily opt-in. We need to enable this settings for awsemf exporter so that customer can enable it if they want.

Describe the solution you'd like
We just need to utilize the exporterhelper module with this new option.

Look this issue #1359 for more details.

@hossain-rayhan
Copy link
Contributor Author

Closed by #1552

@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Vendor Thrift dependency

* Fix build

* Changelog entry

* Ignore third_party for coverage purposes

* Re-run tests

* Re-run tests

* Re-run tests

* Re-run tests

* Relax time comparisons

Fixes #1559.

Some unit tests were flaking in CI because they expected the timestamp
to advance during a test, when it's possible for it to be unchanged
instead. This change switches the offending "<" comparisons to "<=".

* Re-run tests

* Relax more time comparisons

* Re-run tests

Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants