-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanmetricsprocessor: Set resource attributes where possible #18502
Labels
connector/spanmetrics
enhancement
New feature or request
processor/spanmetrics
Span Metrics processor
Comments
gouthamve
added
enhancement
New feature or request
needs triage
New item requiring triage
labels
Feb 10, 2023
gouthamve
changed the title
Set resource attributes where possible
spanmetricsprocessor: Set resource attributes where possible
Feb 10, 2023
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@gouthamve @albertteoh I'll implement it only for the |
Pinging code owners for connector/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This was referenced Feb 17, 2023
This was referenced Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
connector/spanmetrics
enhancement
New feature or request
processor/spanmetrics
Span Metrics processor
Component(s)
processor/spanmetrics
Is your feature request related to a problem? Please describe.
I was using the
spanmetricsprocessor
withprometheusexporter
and was surprised to find theservice_name
as a label instead ofjob
.Digging deeper, this is because the processor only sets metric attributes but not resource attributes.
Describe the solution you'd like
I think we should set resource attributes if we are aggregating by a resource attribute.
For example, if we are aggregating by
service.name
andservice.instance.id
, the dimensions in the metrics emitted should be part of resource attributes and not metric attributes.Describe alternatives you've considered
Use the transform processor to move the metric attributes to resource attributes.
Additional context
No response
The text was updated successfully, but these errors were encountered: