Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanmetricsprocessor: Set resource attributes where possible #18502

Closed
gouthamve opened this issue Feb 10, 2023 · 3 comments · Fixed by #19216
Closed

spanmetricsprocessor: Set resource attributes where possible #18502

gouthamve opened this issue Feb 10, 2023 · 3 comments · Fixed by #19216
Assignees
Labels
connector/spanmetrics enhancement New feature or request processor/spanmetrics Span Metrics processor

Comments

@gouthamve
Copy link
Member

Component(s)

processor/spanmetrics

Is your feature request related to a problem? Please describe.

I was using the spanmetricsprocessor with prometheusexporter and was surprised to find the service_name as a label instead of job.

Digging deeper, this is because the processor only sets metric attributes but not resource attributes.

Describe the solution you'd like

I think we should set resource attributes if we are aggregating by a resource attribute.

For example, if we are aggregating by service.name and service.instance.id, the dimensions in the metrics emitted should be part of resource attributes and not metric attributes.

Describe alternatives you've considered

Use the transform processor to move the metric attributes to resource attributes.

Additional context

No response

@gouthamve gouthamve added enhancement New feature or request needs triage New item requiring triage labels Feb 10, 2023
@gouthamve gouthamve changed the title Set resource attributes where possible spanmetricsprocessor: Set resource attributes where possible Feb 10, 2023
@github-actions github-actions bot added the processor/spanmetrics Span Metrics processor label Feb 10, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@kovrus kovrus self-assigned this Feb 10, 2023
@kovrus kovrus removed the needs triage New item requiring triage label Feb 13, 2023
@kovrus
Copy link
Member

kovrus commented Feb 15, 2023

@gouthamve @albertteoh I'll implement it only for the spanmetrics connector, I'll keep the processor as it is.

@github-actions
Copy link
Contributor

Pinging code owners for connector/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/spanmetrics enhancement New feature or request processor/spanmetrics Span Metrics processor
Projects
None yet
2 participants