Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cumulativetodeltaprocessor] Improve metric name configuration #5877

Closed
alanwest opened this issue Oct 22, 2021 · 3 comments · Fixed by #8952
Closed

[cumulativetodeltaprocessor] Improve metric name configuration #5877

alanwest opened this issue Oct 22, 2021 · 3 comments · Fixed by #8952

Comments

@alanwest
Copy link
Member

#4444 originally changed the cumulative to delta processor to default to converting all cumulative metrics to delta. This behavior was reverted and currently the configuration requires a user identify each cumulative metric by exact name for conversion to delta.

One proposal is to implement regex support #4444 (comment).

Another thought is to do away with the metric name configuration entirely. That is, by installing this processor into your pipeline you're declaring you want delta metrics. This thought is inspired by open-telemetry/opentelemetry-specification#2032 where the ability to configure aggregation temporality at the view level in an SDK was removed. Aggregation temporality would be overridable at the metric reader/exporter.

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Mar 21, 2022

I'd like to take a look at this issue. @jpkrohling, @codeboten, @bogdandrutu what is the appetite for removing the metric name configuration entirely vs regex support?

@jpkrohling
Copy link
Member

I'll defer to @bogdandrutu and @codeboten, but just make sure that if we decide to change this, we do in stages, so that current users of this processor have a chance of migrating without being caught by surprise.

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Mar 23, 2022

If the solution is to use regex instead of converting all metrics, how does everyone feel about providing an "opt-in" and "opt-out" approach? There may also be times when it is easier to specify which metrics should not be converted. Regex could be supported for both option. The config could look something like:

cumulativetodelta:
  mode: include | exclude
  match_type: strict | regex
  metrics: [ <metric_name>, <metric_name>, ...] 
  max_staleness: int

Or reuse the existing include/exclude logic:

cumulativetodelta:
  max_staleness: int
  <include|exclude>:
    match_type: strict | regex
    metrics: [ <metric_name>, <metric_name>, ...] 

with exclude taking precedence over include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants