-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove MetricsLevel
from TelemetrySettings
#11061
Comments
@bogdandrutu Are you going to submit any changes to the spec related to this? (Maybe related to open-telemetry/opentelemetry-specification/issues/4200?) |
Given that stabilization of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A discussion on 4-Sept-2024 lead to the agreement that the struct field
MetricsLevel
will be removed fromTelemetrySettings
. This field is there to allow component authors to check a level before deciding whether to incur the cost of calculating an expensive operation.The alternative for component authors will be to check whether an instrument is enabled or not prior to calculating the metric. This is dependent on the PR in otel go to implement this and on the spec to stabilize this feature.
The decision was that if the change would take too long to implement upstream, then we would remove this field and move any component to configure their own metric level instead. This will allow the unblocking of the component module stabilization work.
The text was updated successfully, but these errors were encountered: