Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles support to OTLP HTTP exporter #11450

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Oct 15, 2024

Description

This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires #11226✅ to be merged first.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.12%. Comparing base (388bae7) to head (ed05199).

Files with missing lines Patch % Lines
exporter/otlphttpexporter/factory.go 80.00% 2 Missing and 2 partials ⚠️
exporter/otlphttpexporter/otlp.go 88.88% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11450      +/-   ##
==========================================
- Coverage   92.14%   92.12%   -0.02%     
==========================================
  Files         433      433              
  Lines       20389    20441      +52     
==========================================
+ Hits        18787    18831      +44     
- Misses       1238     1243       +5     
- Partials      364      367       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Oct 16, 2024

I merged #11226 :)

@dmathieu dmathieu marked this pull request as ready for review October 16, 2024 11:35
@dmathieu dmathieu requested a review from a team as a code owner October 16, 2024 11:35
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @open-telemetry/collector-approvers I will merge this on Friday EU morning unless there are comments before then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants