Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric correctness support to testbed #1605

Closed
wants to merge 1 commit into from
Closed

Add metric correctness support to testbed #1605

wants to merge 1 commit into from

Conversation

pmcollins
Copy link
Member

Description: This change adds support for end-to-end metrics correctness tests using generated PICT files.

Link to tracking Issue: #652

Documentation: metrics/doc.go

@codecov
Copy link

codecov bot commented Aug 20, 2020 •
edited
Loading

Codecov Report

Merging #1605 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         264      264           
  Lines       19960    19960           
=======================================
  Hits        18446    18446           
  Misses       1087     1087           
  Partials      427      427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaaebf1...90f34b5. Read the comment docs.

@pmcollins pmcollins marked this pull request as ready for review August 20, 2020 18:58
@bogdandrutu bogdandrutu self-assigned this Aug 26, 2020
@bogdandrutu
Copy link
Member

Please rebase after #1697 is merged :)

@bogdandrutu
Copy link
Member

Lots of changes in the validator related to rename of the assertion, can this be extracted in a separate PR? Validator is mostly for tracing can it be moved in traces package?

@pmcollins
Copy link
Member Author

Lots of changes in the validator related to rename of the assertion, can this be extracted in a separate PR? Validator is mostly for tracing can it be moved in traces package?

Sure, I'll send out a new PR in a bit.

@pmcollins
Copy link
Member Author

Closing due to splitting this into two PRs.

@pmcollins pmcollins closed this Sep 1, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
@atoulme
Add example showing how to use the HEC raw event parsing endpoint (op…
df8fad2 
…en-telemetry#1605)

* Add example showing how to use the HEC raw event parsing endpoint

* Delete .gitignore

* Update docker-compose.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@dmitryax dmitryax Awaiting requested review from dmitryax

@james-bebbington james-bebbington Awaiting requested review from james-bebbington

@nilebox nilebox Awaiting requested review from nilebox

@owais owais Awaiting requested review from owais

@pjanotti pjanotti Awaiting requested review from pjanotti

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmcollins @bogdandrutu