Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in copy data, the data were not deeply copied #1683

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Aug 30, 2020

Updates #1674

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #1683 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         265      265              
  Lines       19818    19824       +6     
==========================================
+ Hits        18290    18294       +4     
- Misses       1099     1100       +1     
- Partials      429      430       +1     
Impacted Files Coverage Δ
consumer/pdata/metric.go 76.78% <100.00%> (+1.31%) ⬆️
translator/internaldata/resource_to_oc.go 87.03% <0.00%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c9e7f...884aed3. Read the comment docs.

@bogdandrutu bogdandrutu merged commit a1ec7a8 into open-telemetry:master Aug 31, 2020
@bogdandrutu bogdandrutu deleted the fixcopydata branch August 31, 2020 02:21
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* initial version of the pulsar exporter (metrics). Tests yet to be added. (open-telemetry#1541)

authored-by: Shiva Param <[email protected]>
authored-by: Narasimha Rao <[email protected]>
authored-by: narasimharaojm <[email protected]>

* pulsarexporter: fix lint, remove failing tests (open-telemetry#1682)

This is an experimental component added by PayPal. Unit tests to be added later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants