Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exprfilterprocessor skeleton #1844

Closed
wants to merge 4 commits into from
Closed

Add exprfilterprocessor skeleton #1844

wants to merge 4 commits into from

Conversation

pmcollins
Copy link
Member

@pmcollins pmcollins commented Sep 24, 2020

Description: Adds an exprfilterprocessor skeleton.

Testing: Unit tests added.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1844 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1844      +/-   ##
==========================================
- Coverage   91.29%   91.29%   -0.01%     
==========================================
  Files         273      275       +2     
  Lines       16365    16387      +22     
==========================================
+ Hits        14940    14960      +20     
- Misses        998      999       +1     
- Partials      427      428       +1     
Impacted Files Coverage Δ
processor/exprfilterprocessor/factory.go 100.00% <100.00%> (ø)
processor/exprfilterprocessor/processor.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 87.23% <0.00%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ac90b...800dbb9. Read the comment docs.

@pmcollins
Copy link
Member Author

contribtest failure appears unrelated to this change

@pmcollins
Copy link
Member Author

Any thoughts on a name for this package and processor @keitwb and @jrcamp? typeStr filter and package filterprocessor are taken. Do we want to use labelfilter/labelfilterprocessor or use something else like expfilter/expfilterprocessor?

@keitwb
Copy link
Contributor

keitwb commented Sep 28, 2020

It should also be able to filter on metric name so I would avoid calling it label anything. Also this is basically a datapoint filter in the end right or would it also be expanded to work with logs/traces?

@pmcollins
Copy link
Member Author

pmcollins commented Sep 28, 2020

It should also be able to filter on metric name so I would avoid calling it label anything. Also this is basically a datapoint filter in the end right or would it also be expanded to work with logs/traces?

Yeah I have the same reservations about label. It's just a datapoint filter and I'm not aware of plans to expand to logs or traces, or whether it would be useful to have a multi-purpose filter. So... datapointfilter? :-) cc: @bogdandrutu @tigrannajaryan

@pmcollins
Copy link
Member Author

Renamed to exprfilter.

@pmcollins pmcollins changed the title Add labelfilterprocessor skeleton Add exprfilterprocessor skeleton Sep 29, 2020
@rmfitzpatrick
Copy link
Contributor

rmfitzpatrick commented Sep 29, 2020

Would you be able to provide a readme with what this intends to accomplish/provide? Is this an implementation of #560?

edit: see it was removed w/ 4ecdce3. I think providing some context in this diff would be helpful though.

@tigrannajaryan
Copy link
Member

@pmcollins yes, please provide the context of the change, what's the goal. Also, if this is a POC I suggest to move this to contrib repo.

@pmcollins
Copy link
Member Author

Would you be able to provide a readme with what this intends to accomplish/provide? Is this an implementation of #560?

edit: see it was removed w/ 4ecdce3. I think providing some context in this diff would be helpful though.

Yeah, we're going in a different direction than the proposal in the first readme so I deleted it. The design has been somewhat in flux but I'll capture what we have in a new readme.

@pmcollins
Copy link
Member Author

@pmcollins yes, please provide the context of the change, what's the goal. Also, if this is a POC I suggest to move this to contrib repo.

Have been working with Ben and Jay who know the context, but will add a readme and move to contrib.

@pmcollins pmcollins closed this Sep 29, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* use openjdk image in collectd-kafka test

* Release v0.57.0
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants