Remove dead code from oc_to_resource #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't allocate attributes slice explicitly anymore, we don't need to count attributes
dmitryax
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
bogdandrutu
approved these changes
Apr 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
- Coverage 85.95% 85.94% -0.01%
==========================================
Files 157 157
Lines 11841 11834 -7
==========================================
- Hits 10178 10171 -7
Misses 1296 1296
Partials 367 367
Continue to review full report at Codecov.
|
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
Since we don't allocate attributes slice explicitly anymore, we don't need to count attributes
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't allocate attributes slice explicitly anymore, we don't need to count attributes