[Geneva Exporter] Allocate exception from stack instead of heap (#470)

open-telemetry · Jul 20, 2024 · 10f769b · 10f769b
1 parent d953d32
commit 10f769b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/exporters/fluentd/include/opentelemetry/exporters/geneva/geneva_logger_exporter.h b/exporters/fluentd/include/opentelemetry/exporters/geneva/geneva_logger_exporter.h
@@ -37,7 +37,7 @@ static inline bool InitializeGenevaExporter( const GenevaExporterOptions options
  return true;
  } else {
 #if defined(__EXCEPTIONS)
- throw new std::runtime_error("Invalid endpoint! Unix domain socket should have unix:// as url-scheme");
+ throw std::runtime_error("Invalid endpoint! Unix domain socket should have unix:// as url-scheme");
 #endif
  return false;
  }

diff --git a/exporters/fluentd/include/opentelemetry/exporters/geneva/geneva_tracer_exporter.h b/exporters/fluentd/include/opentelemetry/exporters/geneva/geneva_tracer_exporter.h
@@ -41,7 +41,7 @@ static inline bool InitializeGenevaExporter( const GenevaExporterOptions options
  return true;
  } else {
 #if defined(__EXCEPTIONS)
- throw new std::runtime_error("Invalid endpoint! Unix domain socket should have unix:// as url-scheme");
+ throw std::runtime_error("Invalid endpoint! Unix domain socket should have unix:// as url-scheme");
 #endif
  return false;
  }

diff --git a/exporters/fluentd/src/log/fluentd_exporter.cc b/exporters/fluentd/src/log/fluentd_exporter.cc
@@ -213,7 +213,7 @@ bool FluentdExporter::Initialize() {
  else {
 #if defined(__EXCEPTIONS)
  // Customers MUST specify valid end-point configuration
- throw new std::runtime_error("Invalid endpoint!");
+ throw std::runtime_error("Invalid endpoint!");
 #endif
  return false;
  }

diff --git a/exporters/fluentd/src/trace/fluentd_exporter.cc b/exporters/fluentd/src/trace/fluentd_exporter.cc
@@ -181,7 +181,7 @@ bool FluentdExporter::Initialize() {
  else {
 #if defined(__EXCEPTIONS)
  // Customers MUST specify valid end-point configuration
- throw new std::runtime_error("Invalid endpoint!");
+ throw std::runtime_error("Invalid endpoint!");
 #endif
  return false;
  }