Skip to content

Commit

Permalink
Don't require applications using jaeger exporter to know about libcurl (
Browse files Browse the repository at this point in the history
  • Loading branch information
astitcher authored Jul 26, 2022
1 parent 30b4fcd commit 3a8f913
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions ext/src/http/client/curl/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,17 @@ if(CURL_FOUND)
PROPERTIES EXPORT_NAME http_client_curl)

if(TARGET CURL::libcurl)
target_link_libraries(opentelemetry_http_client_curl
PUBLIC opentelemetry_ext CURL::libcurl)
target_link_libraries(
opentelemetry_http_client_curl
PUBLIC opentelemetry_ext
PRIVATE CURL::libcurl)
else()
target_include_directories(opentelemetry_http_client_curl
INTERFACE "${CURL_INCLUDE_DIRS}")
target_link_libraries(opentelemetry_http_client_curl
PUBLIC opentelemetry_ext ${CURL_LIBRARIES})
target_link_libraries(
opentelemetry_http_client_curl
PUBLIC opentelemetry_ext
PRIVATE ${CURL_LIBRARIES})
endif()

install(
Expand Down

2 comments on commit 3a8f913

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 3a8f913 Previous: 30b4fcd Ratio
BM_SpinLockThrashing/1/process_time/real_time 3.831638608660017 ms/iter 0.13245246150525533 ms/iter 28.93
BM_SpinLockThrashing/2/process_time/real_time 4.187779767172677 ms/iter 0.3878456443103392 ms/iter 10.80
BM_ProcYieldSpinLockThrashing/1/process_time/real_time 4.740748554468155 ms/iter 0.43162487922830783 ms/iter 10.98

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 3a8f913 Previous: 30b4fcd Ratio
BM_LockFreeBuffer/1 4224575.519561768 ns/iter 359725.63942375436 ns/iter 11.74
BM_LockFreeBuffer/2 3706051.5880584717 ns/iter 1787047.6245880127 ns/iter 2.07

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.