Skip to content

Commit

Permalink
[BUILD] fix nlohmann_json's (third party) include dir (#1415)
Browse files Browse the repository at this point in the history
  • Loading branch information
@leodido
leodido authored May 24, 2022
1 parent 0ef9446 commit 5c8f476
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/nlohmann-json.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ExternalProject_Add(nlohmann_json_download
)

ExternalProject_Get_Property(nlohmann_json_download INSTALL_DIR)
SET(NLOHMANN_JSON_INCLUDE_DIR ${INSTALL_DIR}/third_party/src/nlohmann_json_download/single_include)
SET(NLOHMANN_JSON_INCLUDE_DIR ${INSTALL_DIR}/src/nlohmann_json_download/single_include)
add_library(nlohmann_json_ INTERFACE)
target_include_directories(nlohmann_json_ INTERFACE
"$<BUILD_INTERFACE:${NLOHMANN_JSON_INCLUDE_DIR}>"
Expand Down

2 comments on commit 5c8f476

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5c8f476 Previous: 0ef9446 Ratio
BM_BaselineBuffer/1 13300056.457519531 ns/iter 5012726.783752441 ns/iter 2.65
BM_BaselineBuffer/2 6669015.884399414 ns/iter 3018313.6463165283 ns/iter 2.21
BM_LockFreeBuffer/1 3273436.0694885254 ns/iter 300963.7469492891 ns/iter 10.88
BM_LockFreeBuffer/2 3444717.930895942 ns/iter 868806.8389892578 ns/iter 3.96

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp exporters Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5c8f476 Previous: 0ef9446 Ratio
BM_otlp_grpc_with_collector 2289259.6674900427 ns/iter 982237.7880800117 ns/iter 2.33

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.