Skip to content

Commit

Permalink
[Code health] Expand iwyu coverage to include unit tests. (#3022)
Browse files Browse the repository at this point in the history
  • Loading branch information
@marcalff
marcalff authored Aug 8, 2024
1 parent 7c6b9db commit cc60934
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/iwyu.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ jobs:
-DCMAKE_CXX_STANDARD=14 \
-DWITH_STL=CXX14 \
-DCMAKE_CXX_INCLUDE_WHAT_YOU_USE="include-what-you-use;-w;-Xiwyu;--mapping_file=${TOPDIR}/.iwyu.imp;" \
-DBUILD_TESTING=OFF \
-DBUILD_W3CTRACECONTEXT_TEST=OFF \
-DBUILD_TESTING=ON \
-DBUILD_W3CTRACECONTEXT_TEST=ON \
-DWITH_OTLP_GRPC=OFF \
-DWITH_OTLP_HTTP=ON \
-DWITH_OTLP_FILE=ON \
Expand Down

1 comment on commit cc60934

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: cc60934 Previous: 7c6b9db Ratio
BM_SpinLockThrashing/1/process_time/real_time 0.5384604675862906 ms/iter 0.11022491455078125 ms/iter 4.89
BM_SpinLockThrashing/2/process_time/real_time 1.301838241460669 ms/iter 0.19538105359698266 ms/iter 6.66
BM_SpinLockThrashing/4/process_time/real_time 2.489626407623291 ms/iter 0.5929039584265815 ms/iter 4.20
BM_ProcYieldSpinLockThrashing/2/process_time/real_time 0.8307670682205437 ms/iter 0.1702752503209144 ms/iter 4.88
BM_ProcYieldSpinLockThrashing/4/process_time/real_time 1.7241406440734863 ms/iter 0.57931337505579 ms/iter 2.98
BM_NaiveSpinLockThrashing/4/process_time/real_time 1.645364761352539 ms/iter 0.6095193467050228 ms/iter 2.70
BM_ThreadYieldSpinLockThrashing/1/process_time/real_time 15.642523765563965 ms/iter 7.4260611283151725 ms/iter 2.11

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.