Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs SDK] Provide builders to avoid exposing SDK internals #1486

Closed
marcalff opened this issue Jul 11, 2022 · 0 comments · Fixed by #1524
Closed

[Logs SDK] Provide builders to avoid exposing SDK internals #1486

marcalff opened this issue Jul 11, 2022 · 0 comments · Fixed by #1524
Assignees
@marcalff
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

Same as issue #1393, but for Logs.

Please assign to me.
@marcalff marcalff added the bug Something isn't working label Jul 11, 2022
@marcalff marcalff mentioned this issue Jul 12, 2022
Merged
4 tasks
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 28, 2022
@marcalff
Fix log sdk builder (open-telemetry#1486)
925d18b
@marcalff marcalff mentioned this issue Jul 28, 2022
Merged
3 tasks
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 28, 2022
@marcalff
Fix log sdk builder (open-telemetry#1486)
a13add0 
Fixed bazel build.
Added CHANGELOG entry.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 28, 2022
@marcalff
Fix log sdk builder (open-telemetry#1486)
5996d8d 
Code cleanup
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 29, 2022
@marcalff
Fix log sdk builder (open-telemetry#1486)
6e2cc90 
Implemented code review comments.

Fixed typo (processor -> processors)
in TracerContextFactory
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Aug 1, 2022
@marcalff
Fix log sdk builder (open-telemetry#1486)
0595c68 
CHANGELOG cleanup after 1.5.0 release.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Aug 1, 2022
@marcalff
Fix log sdk builder (open-telemetry#1486)
f6ab143 
Implemented code review comments,
added unit tests.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Aug 1, 2022
@marcalff
Fix log sdk builder (open-telemetry#1486)
fa5dd8d 
Fixed build break.
lalitb pushed a commit that referenced this issue Aug 2, 2022
@marcalff
Fix log sdk builder (#1486) (#1524)
70fd2dc
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@marcalff @yxue
Fix log sdk builder (open-telemetry#1486) (open-telemetry#1524)
efd9596
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@marcalff @yxue
Fix log sdk builder (open-telemetry#1486) (open-telemetry#1524)
02ed844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix log sdk builder (#1486) marcalff/opentelemetry-cpp
1 participant
@marcalff