Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics] Upgrade instrumentation_library_metrics to scope_metrics #1492

Closed
owent opened this issue Jul 12, 2022 · 0 comments · Fixed by #1507
Closed

[Metrics] Upgrade instrumentation_library_metrics to scope_metrics #1492

owent opened this issue Jul 12, 2022 · 0 comments · Fixed by #1507
Assignees
@owent
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics
Milestone
Metrics SDK - Rel...

Comments

@owent
Copy link
Member

owent commented Jul 12, 2022 •
edited
Loading

Is your feature request related to a problem?

According to https:/open-telemetry/opentelemetry-proto/blob/v0.17.0/opentelemetry/proto/metrics/v1/metrics.proto ,
instrumentation_library_metrics is deprecated and removed in https:/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto , we should upgrade to use scope_metrics instead, just like traces and logs.

Describe the solution you'd like

  • Change the name of instrumentation_info_metric_data_ in ResourceMetrics and instrumentation_info_metrics in MetricCollector::Collect
  • PopulateResourceMetrics to scope_metrics in OTLP exporters
  • Rename InstrumentationInfoMetrics to ScopeMetrics
  • Rename instrumentation_library_ to scope_
  • Rename instrumentation_metrics to scope_metrics
@lalitb lalitb added the metrics label Jul 13, 2022
@lalitb lalitb added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Jul 13, 2022
@owent owent self-assigned this Jul 20, 2022
This was referenced Jul 20, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owent owent

Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics
Projects
None yet
Milestone
Metrics SDK - Release Candidate
Development

Successfully merging a pull request may close this issue.

Upgrade instrumentation_library_metrics to scope_metrics owent/opentelemetry-cpp
2 participants
@lalitb @owent