Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove throw check from metrics tests with noexcept #1559

Closed
esigo opened this issue Aug 11, 2022 · 0 comments · Fixed by #1560
Closed

remove throw check from metrics tests with noexcept #1559

esigo opened this issue Aug 11, 2022 · 0 comments · Fixed by #1560
Labels
bug Something isn't working

Comments

@esigo
Copy link
Member

esigo commented Aug 11, 2022

we have exception checks in metrics test which cannot throw anyway. These checks has to be removed so we can use the tests in bazel.noexcept.
@esigo esigo added the bug Something isn't working label Aug 11, 2022
@esigo esigo mentioned this issue Aug 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove throw check from metrics with noexcept esigo/opentelemetry-cpp
1 participant
@esigo