Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore more warnings for generated protobuf files. #2065

Closed
owent opened this issue Mar 17, 2023 · 3 comments · Fixed by #2067
Closed

Ignore more warnings for generated protobuf files. #2065

owent opened this issue Mar 17, 2023 · 3 comments · Fixed by #2067

Comments

@owent
Copy link
Member

owent commented Mar 17, 2023

Is your feature request related to a problem?
We enable more warnings in our project and some of them will be triggered by generated protobuf files.(-Wconversion, -Wshadow, -Wsuggest-override for gCC/Clang, C4484, C4485, C5037, C6001, C6244, C6246 for MSVC and so on.).And bcause we enable -Werror and /WX in our project , these warning will be converted to errors when compiling.

Can I add codes to ingnore these warning in protobuf_include_prefix.h ?

Describe the solution you'd like

Exclude these warnings in protobuf_include_prefix.h .

@lalitb
Copy link
Member

lalitb commented Mar 20, 2023

Just curious, if these warnings are triggered by protobuf files, and as of now not ignored in protobuf_include_prefix.h, do we know why are they not failing our maintainer mode CI tests ?

@owent
Copy link
Member Author

owent commented Mar 21, 2023

These warnings are not included in -Wall and -Wextra.

@lalitb
Copy link
Member

lalitb commented Mar 21, 2023

Ok thanks. Yes, I think we can ignore these warnings in protobuf_include_prefix.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants