Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WITH_OTLP_HTTP_SSL_PREVIEW mainstream #2365

Closed
marcalff opened this issue Oct 12, 2023 · 3 comments · Fixed by #2378
Closed

Make WITH_OTLP_HTTP_SSL_PREVIEW mainstream #2365

marcalff opened this issue Oct 12, 2023 · 3 comments · Fixed by #2378
Assignees
@marcalff
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

To discuss.

HTTP SSL support has been stable for a while.

The preview flag can be removed, and the code be mainstream (without ifdef).

This will decrease the overall complexity, and simplify CI builds.

Likewise for WITH_OTLP_HTTP_SSL_TLS_PREVIEW.
@marcalff marcalff added the bug Something isn't working label Oct 12, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 12, 2023
@lalitb
Copy link
Member

lalitb commented Oct 12, 2023

Agree

@kkuehl
Copy link

kkuehl commented Oct 13, 2023

Successfully using in production for weeks.

@marcalff
Copy link
Member Author

Successfully using in production for weeks.

@kkuehl Thanks for the feedback, this is good to know.

When nothing is reported, we are in the dark and left to wonder if a feature is working just fine or if it is not even used.

Making this mainstream then.

@marcalff marcalff self-assigned this Oct 18, 2023
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 18, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Oct 18, 2023
@marcalff
Fixes open-telemetry#2365
a787326
@marcalff marcalff mentioned this issue Oct 18, 2023
Merged
3 tasks
@marcalff marcalff mentioned this issue Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Make WITH_OTLP_HTTP_SSL_PREVIEW mainstream marcalff/opentelemetry-cpp
3 participants
@lalitb @kkuehl @marcalff