Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning with DoubleUpDownCounter and negative values in 1.12.0 #2377

Closed
timwoj opened this issue Oct 18, 2023 · 0 comments · Fixed by #2379
Closed

Warning with DoubleUpDownCounter and negative values in 1.12.0 #2377

timwoj opened this issue Oct 18, 2023 · 0 comments · Fixed by #2379
Assignees
@lalitb
Labels
bug Something isn't working

Comments

@timwoj
Copy link
Contributor

timwoj commented Oct 18, 2023

Describe your environment
otel-cpp: v1.12.0
Platform: macOS (but happens on others as well)

Steps to reproduce

  • Create a DoubleUpDownCounter
  • Add a negative value to it

What is the expected behavior?
The counter's value is decremented by the value.

What is the actual behavior?

[Warning] File: /Users/tim/Desktop/projects/opentelemetry-cpp/sdk/src/metrics/aggregation/sum_aggregation.cc:90  DoubleSumAggregation::Aggregate Negative value ignored for Monotonic increasing measurement. Value-374.1

Additional context
Attached is a patch for the metrics_simple example that exhibits the problem.

updown.patch
@timwoj timwoj added the bug Something isn't working label Oct 18, 2023
@timwoj timwoj changed the title Warning with DoubleUpDownCounter in 1.12.0 Warning with DoubleUpDownCounter and negative values in 1.12.0 Oct 18, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 18, 2023
@lalitb lalitb self-assigned this Oct 18, 2023
@lalitb lalitb mentioned this issue Oct 19, 2023
Merged
3 tasks
@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK] Creating DoubleUpDownCounter with no matching view lalitb/opentelemetry-cpp
3 participants
@lalitb @timwoj @marcalff