-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Support for Logger::Enabled() is incomplete #2667
Labels
abi:version_2
Fix is available WITH_ABI_VERSION_2
breaking change
API or ABI breaking change
bug
Something isn't working
Stale
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Comments
github-actions
bot
added
the
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
label
May 14, 2024
To revisit once spec is merged: |
Spec is now merged. Adding a |
marcalff
added
abi:version_2
Fix is available WITH_ABI_VERSION_2
breaking change
API or ABI breaking change
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
May 28, 2024
This issue was marked as stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
abi:version_2
Fix is available WITH_ABI_VERSION_2
breaking change
API or ABI breaking change
bug
Something isn't working
Stale
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Logger::Enabled() always return false.
This is due to:
The severity is kMaxSeverity by default, meaning all events are disabled by default.
There is a method to change the logger severity:
but is it protected, and never called in the code base.
Any user code that checks for Enabled() can not emit logs.
Note that EmitLogRecord() helpers never honor the Enabled() flag either.
The text was updated successfully, but these errors were encountered: