Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC Instrumentation #530

Closed
lalitb opened this issue Jan 25, 2021 · 10 comments
Closed

Add gRPC Instrumentation #530

lalitb opened this issue Jan 25, 2021 · 10 comments
Labels
good first issue Good for newcomers priority:p2 Issues that are not blocking

Comments

@lalitb
Copy link
Member

lalitb commented Jan 25, 2021

Add support for gRPC C++ client and server api calls instrumentation either using

@lalitb lalitb changed the title Add gRPC Instrumentation for C++ Add gRPC Instrumentation Jan 25, 2021
@lalitb lalitb added good first issue Good for newcomers priority:p2 Issues that are not blocking labels Jan 27, 2021
@ovidiubuligan
Copy link

I see a B3Propagator was commited today , Is this the recomended format for trace propagation? Or should the W3C format be used ?

@lalitb
Copy link
Member Author

lalitb commented Jan 28, 2021

I see a B3Propagator was commited today , Is this the recomended format for trace propagation? Or should the W3C format be used ?

From instrumentation library prospective, it can be assumed that the right type of propagator would be already set ( refer : https:/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#global-propagators ). While it is not yet implemented for C++ ( #540), there would be api to set and get default propagator, which would be usable from instrumentation library.

@bryanuribe
Copy link

Is this still open/available? Would I be able to pick this up?
cc: @alolita

@maxgolov
Copy link
Contributor

maxgolov commented May 12, 2021

I see a B3Propagator was commited today , Is this the recomended format for trace propagation? Or should the W3C format be used ?

Depends on your cloud service provider. w3c TraceContext is the default endorsed and recommended:
https://www.w3.org/blog/2019/12/trace-context-enters-proposed-recommendation/

B3 is optional and supposed to live in external package.

@maxgolov
Copy link
Contributor

@bryanuribe - in terms of gRPC w3c context propagation, I think @Hablapatabla is already working in this direction:
#729
You can join our channel on Slack to discuss more. Slack channel has more context.

@maxgolov
Copy link
Contributor

@alolita - let's discuss this item during C++ SIG call. I guess what we need to achieve:

  • generic example that shows how to use ANY propagator: standard + extended set.
  • possibly a helper template / utility class that allows our customers to plug in any propagator of their choice.
  • validation effort associated with verifying E2E that all propagators are functional.

I can help with W3C Trace Context validation, early customer feedback, etc. I have customers lined up for that already.

@maxgolov
Copy link
Contributor

@bryanuribe - would you be able to join the next C++ SIG meeting? It would be immensely helpful if you can help us with B3 context propagator validation, and maybe covering Amazon-specific context propagator in contrib repo. Slack channel where we can discuss it:
https://cloud-native.slack.com/archives/C01SM7Y71DJ

@bryanuribe
Copy link

@maxgolov Yes, I will be at the next SIG meeting. Awesome, I will reach out to you over slack

@alolita
Copy link
Member

alolita commented May 14, 2021

@maxgolov will join in for the next SIG meeting - let's discuss.

@lalitb
Copy link
Member Author

lalitb commented Jun 7, 2021

#729 closes this

@lalitb lalitb closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:p2 Issues that are not blocking
Projects
None yet
Development

No branches or pull requests

5 participants