Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel build for grpc example #838

Closed
lalitb opened this issue Jun 8, 2021 · 5 comments
Closed

Add bazel build for grpc example #838

lalitb opened this issue Jun 8, 2021 · 5 comments
Labels
area:sdk:instrumentation bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers Stale

Comments

@lalitb
Copy link
Member

lalitb commented Jun 8, 2021

grpc example ( https:/open-telemetry/opentelemetry-cpp/tree/main/examples/grpc ) supports only cmake build as of now. bazel build needs to be added.

cc @jsuereth added bug as discussed here : #729 (review)

@lalitb lalitb added bug Something isn't working good first issue Good for newcomers area:sdk:instrumentation labels Jun 8, 2021
@owent
Copy link
Member

owent commented Jun 18, 2021

I'm interesting in this. There some problems in #666 before.

  • The old gRPC do not support legacy compilers and bazel 4.
  • There are also more problems if using C++20 (Which remove many deprecated APIs before) even we use the gRPC with the version is not that old.

I'm not familiar with bazel and I think there may be the same problems if we add bazel support for grpc example.
Looking for the solution of best pratice.

@lalitb
Copy link
Member Author

lalitb commented Jun 18, 2021

For the gcc compiler, we can document the minimum supported gcc version for gRPC/otlp as defined by gRPC (4.9+ or 5.1+ whatever works) :
gRPC needs gcc 4.9+(https://grpc.io/docs/), and abseil needs gcc 5.1+ (https://abseil.io/docs/cpp/platforms/platforms).

We can further split our Bazeil build CI into two parts - 4.8 compiler without building grpc/otlp, 5.1+ compiler with grpc/otlp. This will allow us to upgrade Bazel and gRPC versions both.

If all are fine, I can create a PR for updating our docs, and splitting Bazel build.

@lalitb
Copy link
Member Author

lalitb commented Jun 18, 2021

I am putting it as help needed, probably someone with good knowledge bazel can help here.

@lalitb lalitb added the help wanted Good for taking. Extra help will be provided by maintainers label Jun 18, 2021
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 11, 2021
@lalitb
Copy link
Member Author

lalitb commented Nov 11, 2021

#910 fixes it.

@lalitb lalitb closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk:instrumentation bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers Stale
Projects
None yet
Development

No branches or pull requests

2 participants