Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports span attributes to ETW #1021

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

ThomsonTan
Copy link
Contributor

Changes

Span attributes are current ignored in ETW exporter, this PR add the support.

BTW: if there are multiple writes to the same attribute name, the last one wins.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team October 20, 2021 06:01
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1021 (ed834df) into main (55a6517) will not change coverage.
The diff coverage is n/a.

❗ Current head ed834df differs from pull request most recent head 93f15d6. Consider uploading reports for the commit 93f15d6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         151      151           
  Lines        5972     5972           
=======================================
  Hits         5664     5664           
  Misses        308      308           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding. Can we add the test case for this?

@lalitb lalitb merged commit cc065f7 into open-telemetry:main Oct 20, 2021
@ThomsonTan ThomsonTan deleted the SpanAttributesInETWExporter branch November 9, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants