checkout opentelemetry-proto v0.11.0 #1055
Conversation
store release tags in a file
Codecov Report
@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 151 151
Lines 5971 5971
=======================================
Hits 5663 5663
Misses 308 308 |
| nlohmann-json=v3.9.1 | ||
| opentelemetry-proto=v0.11.0 | ||
| prometheus-cpp=v0.11.0 | ||
| vcpkg=2020.04-2702-g5568f110b |
There was a problem hiding this comment.
Sorry if I am missing something. What is the purpose of adding this file, and also adding an option in do_ci.sh to create this file? Is it meant to be a central place to list versions of all the otel-cpp dependencies?
There was a problem hiding this comment.
I believe it's a good idea to have the versions documented somewhere so the users can download the versions of the dependencies that a release has been published with. This would be obsolete if the plan is to not support older opentelemetry versions though.
There was a problem hiding this comment.
Ok, that makes sense. Just wondering if this should also contain the dependencies not coming as submodules, eg gRPC(v1.39.1), thrift (0.14.1), abseil(20210324.0)?
There was a problem hiding this comment.
yes absolutely. Just added them to the script.
Related to #1051 (issue)
Changes
checkout opentelemetry-proto v0.11.0 and store the third_party release tags in a file
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes