Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added s390x arch into CMake build. #1216

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Conversation

velemas
Copy link
Contributor

@velemas velemas commented Feb 16, 2022

Signed-off-by: Artiom Vaskov [email protected]

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@velemas velemas requested a review from a team February 16, 2022 13:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2022

CLA Signed

The committers are authorized under a signed CLA.

@esigo
Copy link
Member

esigo commented Feb 16, 2022

@velemas thanks for the PR.
Could you please fix CLA error?

@velemas
Copy link
Contributor Author

velemas commented Feb 16, 2022

@esigo i am working on it, some internal stuff must be settled down

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1216 (af936d5) into main (1fe14b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         198      198           
  Lines        7118     7118           
=======================================
  Hits         6570     6570           
  Misses        548      548           

@lalitb
Copy link
Member

lalitb commented Feb 23, 2022

@velemas - Would you be working to fix CLA, so that the PR can be merged?

@velemas
Copy link
Contributor Author

velemas commented Feb 24, 2022

@lalitb yes, i'm working on it, sorry for the delay

@ThomsonTan
Copy link
Contributor

@lalitb yes, i'm working on it, sorry for the delay

Seems the CLA is still not done. @velemas please let us know if there is any issue.

@velemas
Copy link
Contributor Author

velemas commented Mar 1, 2022

@ThomsonTan it's just a long internal process, hope by the end of the week it is done.

@velemas
Copy link
Contributor Author

velemas commented Mar 2, 2022

@ThomsonTan EasyCLA is covered.

@ThomsonTan ThomsonTan merged commit 84394fd into open-telemetry:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants