fix: use CURLOPT_TIMEOUT_MS to config OtlpHttpExporter's timeout instead of CURLOPT_TIMEOUT #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of CURLOPT_TIMEOUT
Codecov Report
@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
- Coverage 92.31% 92.30% -0.01%
==========================================
Files 198 198
Lines 7281 7281
==========================================
- Hits 6721 6720 -1
- Misses 560 561 +1
|
lalitb
approved these changes
Mar 11, 2022
ThomsonTan
approved these changes
Mar 11, 2022
DebajitDas
pushed a commit
to DebajitDas/opentelemetry-cpp
that referenced
this pull request
Mar 21, 2022
…ead of CURLOPT_TIMEOUT (open-telemetry#1261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1258
Changes
Support OtlpHttpExporter's timeout less than 1s.