Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributesProcessor dtor #1263

Merged
merged 2 commits into from
Mar 13, 2022
Merged

AttributesProcessor dtor #1263

merged 2 commits into from
Mar 13, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Mar 13, 2022

Fixes AttributesProcessor dtor

Changes

Adds AttributesProcessor missing virtual dtor.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team March 13, 2022 11:13
@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1263 (258ca98) into main (28bd621) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +0.01%     
==========================================
  Files         202      202              
  Lines        7335     7336       +1     
==========================================
+ Hits         6775     6776       +1     
  Misses        560      560
Impacted Files Coverage Δ
...ntelemetry/sdk/metrics/view/attributes_processor.h 100.00% <100.00%> (ø)

lalitb
lalitb approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix,

@lalitb lalitb merged commit da94697 into open-telemetry:main Mar 13, 2022
@esigo esigo deleted the AttributesProcessor-dtor branch March 13, 2022 16:47
DebajitDas pushed a commit to DebajitDas/opentelemetry-cpp that referenced this pull request Mar 21, 2022
@esigo @DebajitDas
AttributesProcessor dtor (open-telemetry#1263)
d1a5aa9
@owent owent mentioned this pull request Feb 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esigo @lalitb