Fix Prometheus exporter failure #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esigo
added
area:exporter:prometheus
Codecov Report
@@ Coverage Diff @@
## main #1460 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 154 154
Lines 4373 4373
=======================================
Hits 3730 3730
Misses 643 643 |
lalitb
reviewed
Jun 21, 2022
| { | ||
| sum = nostd::get<long>(histogram_point_data.sum_); | ||
| } | ||
| SetData(std::vector<double>{sum, (double)histogram_point_data.count_}, boundaries, |
There was a problem hiding this comment.
nit - Why do we have std::vector<double> as first argument. Will we need to pass vector of aggregated values in this?
There was a problem hiding this comment.
That came from the legacy exporter code that I reused. The vector is used in SetValue called by SetData, supposedly to have slightly similar overload signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes histogram_point_data.sum_ variant access, also limits the max_collection_size of Prometheus collector needed for unit test.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes