Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TO BE CLOSED] legacy gRPC e2e test #1737

Closed
wants to merge 44 commits into from
Closed

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 5, 2022

Fixes #1634 (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

e2e/WORKSPACE Outdated

git_repository(
name = "io_opentelemetry_cpp",
repo_mapping = {"@com_github_grpc_grpc": "@com_github_grpc_grpc_legacy"},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the user can choose between gRPC versions we support.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #1737 (2d9f3b0) into main (8f778b7) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
+ Coverage   85.77%   85.79%   +0.02%     
==========================================
  Files         171      171              
  Lines        5220     5220              
==========================================
+ Hits         4477     4478       +1     
+ Misses        743      742       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️

@esigo esigo changed the title [For Discussion] legacy gRPC e2e test [TO BE CLOSED] legacy gRPC e2e test Nov 19, 2022
@esigo esigo added the pr:do-not-merge This PR is not ready to be merged. label Nov 19, 2022
@esigo esigo closed this Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:do-not-merge This PR is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump to gRPC v1.48.1 for bazel CIs
1 participant