Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Document that clang-format version 10.0 is used. #1782

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

marcalff
Copy link
Member

Fixes #1781

Changes

In CONTRIBUTING.md,
clarify that clang-format version 10.0 is used.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Document that clang-format version 10.0 is used.
@marcalff marcalff requested a review from a team November 16, 2022 22:36
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1782 (265bf0e) into main (8da88df) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
+ Coverage   85.74%   85.77%   +0.04%     
==========================================
  Files         171      171              
  Lines        5214     5214              
==========================================
+ Hits         4470     4472       +2     
+ Misses        744      742       -2     
Impacted Files Coverage Δ
...include/opentelemetry/sdk/common/circular_buffer.h 98.00% <0.00%> (-2.00%) ⬇️
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

@lalitb lalitb merged commit d0571d8 into open-telemetry:main Nov 17, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff marcalff deleted the doc_clang_format_1781 branch July 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] In CONTRIBUTING.md, clarify how to run clang-format
3 participants