Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy gRPC e2e C++11 CI #1787

Closed
wants to merge 13 commits into from
Closed

Legacy gRPC e2e C++11 CI #1787

wants to merge 13 commits into from

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 19, 2022 •
edited
Loading

Fixes #1634 (issue) step 2/2

depends on #1786

Changes

Adds legacy gRPC e2e C++11 CI.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo added the pr:do-not-merge This PR is not ready to be merged. label Nov 19, 2022
@codecov
Copy link

codecov bot commented Nov 19, 2022 •
edited
Loading

Codecov Report

Merging #1787 (15f18a1) into main (61bc860) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
- Coverage   85.78%   85.74%   -0.03%     
==========================================
  Files         171      171              
  Lines        5243     5243              
==========================================
- Hits         4497     4495       -2     
- Misses        746      748       +2
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️
sdk/src/trace/batch_span_processor.cc 91.48% <0.00%> (+0.78%) ⬆️

@esigo esigo mentioned this pull request Nov 21, 2022
Merged
3 tasks
@esigo esigo marked this pull request as ready for review November 23, 2022 19:04
@esigo esigo requested a review from a team November 23, 2022 19:04
@esigo esigo removed the pr:do-not-merge This PR is not ready to be merged. label Nov 23, 2022
ThomsonTan
ThomsonTan reviewed Nov 23, 2022
View reviewed changes
examples/e2e/WORKSPACE Outdated
@@ -0,0 +1,36 @@
workspace(name = "otel_e2e")

load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, cleaned.

@esigo
Copy link
Member Author

esigo commented Jan 31, 2023

No need for C++11: #1830.

@esigo esigo closed this Jan 31, 2023
@esigo esigo deleted the legacy-gRPC branch January 31, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

Assignees
No one assigned
Labels
build and test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump to gRPC v1.48.1 for bazel CIs
2 participants
@esigo @ThomsonTan