Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix default bazel build #1816

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 28, 2022

Fixes #1802 (issue)

can be tested with (no test target):
bazel query '//... except kind(.*test, //...)' | xargs bazel build --cxxopt=-std=c++14

Changes

moves HttpClientFactory::CreateNoSend() under ENABLE_TEST flag.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team November 28, 2022 17:52
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1816 (41b9ec0) into main (ec90007) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1816   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         171      171           
  Lines        5240     5240           
=======================================
  Hits         4492     4492           
  Misses        748      748           

@esigo esigo enabled auto-merge (squash) November 28, 2022 18:19
@esigo esigo merged commit 368c8bf into open-telemetry:main Nov 28, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILD] Default bazel build fails
3 participants