Log a warning when the BatchSpanProcessor queue is full.

[johanpel]

Fixes #1870

Changes

Adds a warning when a span is dropped in case the BatchSpanProcessor queue is full.

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• [n/a] Changes in public API reviewed

[codecov]

Codecov Report

Merging #1871 (b2961f9) into main (8866c10) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
- Coverage   85.77%   85.71%   -0.05%     
==========================================
  Files         171      171              
  Lines        5240     5241       +1     
==========================================
- Hits         4494     4492       -2     
- Misses        746      749       +3     

Impacted Files	Coverage Δ
sdk/src/trace/batch_span_processor.cc	90.70% <100.00%> (+0.08%)	⬆️
ext/src/http/client/curl/http_client_curl.cc	80.31% <0.00%> (-1.13%)	⬇️

[marcalff]

Thanks @johanpel for the PR.

FYI, there is a delay in running CI, because we have to manually allow it after a new commit, due to github rules for first time contributors.

I see the CLA is signed already, which is great.

Once this PR is merged, the process will be much easier ;-)

[johanpel]

Thanks @johanpel for the PR.

FYI, there is a delay in running CI, because we have to manually allow it after a new commit, due to github rules for first time contributors.

I see the CLA is signed already, which is great.

Once this PR is merged, the process will be much easier ;-)

Makes sense. I've added a few commits to hopefully fix the CI issues. Most were related to the timing around the BatchSpanProcessor. With Valgrind/ASAN/TSAN the BatchSpanProcessor still seems to be able to keep the queue non-full in the BatchSpanProcessorTestPeer/TestManySpansLoss test.

I've reduced the queue size. Hope that gives more consistent results.

[johanpel]

It was still a bit too flaky, added a commit to only check logs if anything is actually dropped.

[owent]

LGTM

[marcalff]

LGTM, thanks for the fix.