Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor metrics handling optimizations #1890

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

ays7
Copy link
Contributor

@ays7 ays7 commented Dec 29, 2022

Minor metrics handling optimizations:

  • avoid few unnecessary copies
  • avoid empty exports with no data points

@ays7 ays7 requested a review from a team December 29, 2022 14:12
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1890 (711b2ba) into main (9197bf3) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
+ Coverage   85.71%   85.78%   +0.07%     
==========================================
  Files         171      171              
  Lines        5241     5243       +2     
==========================================
+ Hits         4492     4497       +5     
+ Misses        749      746       -3     
Impacted Files Coverage Δ
sdk/src/metrics/state/metric_collector.cc 92.86% <100.00%> (+0.55%) ⬆️
sdk/src/metrics/state/temporal_metric_storage.cc 98.22% <100.00%> (ø)
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you fix the formatting so that the CI is successful.

@ays7
Copy link
Contributor Author

ays7 commented Jan 3, 2023

@lalitb thanks for the ref -- missed that format script.
FYI: i took care of my mods, but the format appears to be violated in about a dozen or 2 of files in the repo...

@lalitb
Copy link
Member

lalitb commented Jan 3, 2023

FYI: I took care of my mods, but the format appears to be violated in about a dozen or 2 of files in the repo...

This shouldn't happen if you are using clang-format v10.0. Anyway, the changes looks good now, as CI is successful. Thanks.

@lalitb lalitb merged commit d5f0c48 into open-telemetry:main Jan 3, 2023
@ays7 ays7 deleted the minor-metrics-opts branch May 18, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants