Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade prometheus-cpp to v1.1.0 #1954

Merged
merged 5 commits into from
Feb 5, 2023

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Feb 3, 2023

Fixes # (issue)

Changes

The earlier version v1.0.0 was released on Nov 2021.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team February 3, 2023 19:51
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #1954 (f44a85a) into main (32af352) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1954   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         165      165           
  Lines        4596     4596           
=======================================
  Hits         4004     4004           
  Misses        592      592           

ASSERT_TRUE(false);
break;
case prometheus::MetricType::Untyped:
break;
default:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v.1.1.0 adds a new metric type as MetricType::Info. Adding default to handle that (and keep maintainer mode CI happy).

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@lalitb lalitb merged commit 9200d0c into open-telemetry:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants