Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo GENENV -> GETENV #1972

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

sproberts92
Copy link
Contributor

@sproberts92 sproberts92 commented Feb 9, 2023

Noticed this while making some adjustments to the Conan recipe for opentelemetry-cpp.

Changes

Fix a typo to align with the cmake option defined in the top level CMakeLists.txt.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@sproberts92 sproberts92 requested a review from a team February 9, 2023 04:39
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sproberts92 / name: Samuel Roberts (2f4b0bc)

@ThomsonTan
Copy link
Contributor

@sproberts92 thanks for the fix. Could you please sign the CLA?

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1972 (2f4b0bc) into main (2544803) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1972   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files         165      165           
  Lines        4596     4596           
=======================================
  Hits         4003     4003           
  Misses        593      593           

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lalitb lalitb merged commit d1fd49d into open-telemetry:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants