[SDK] Fix schema URL precedence bug in Resource::Merge
#2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2036 +/- ##
==========================================
+ Coverage 87.30% 87.32% +0.03%
==========================================
Files 166 166
Lines 4723 4723
==========================================
+ Hits 4123 4124 +1
+ Misses 600 599 -1
|
esigo
added
size/M
3 tasks
|
@johanpel - The changes look good. One you feel it is ready, can you make it available for review ? |
ThomsonTan
approved these changes
Mar 10, 2023
marcalff
changed the title
Resource::Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2035
Changes
In
Resource::Mergethis PR will cause the old schema url to be used if the updating schema url is empty. This is in accord with the specification.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes