Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Missed include #2143

Merged
merged 2 commits into from
May 20, 2023
Merged

Conversation

astitcher
Copy link
Contributor

@astitcher astitcher commented May 19, 2023

Fixes #2142

Changes

Added a needed include to avoid compilation error on Fedora 38

@astitcher astitcher requested a review from a team May 19, 2023 22:37
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #2143 (1d068ff) into main (23dfc20) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2143   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         166      166           
  Lines        4777     4777           
=======================================
  Hits         4164     4164           
  Misses        613      613           
Impacted Files Coverage Δ
...include/opentelemetry/ext/http/common/url_parser.h 92.00% <ø> (ø)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

@marcalff marcalff merged commit cfa130b into open-telemetry:main May 20, 2023
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 21, 2023
@marcalff marcalff changed the title Missed include [BUILD] Missed include May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure with Gcc on Fedora 38
4 participants