[BUILD] Fix if check on environment variable and add CMake variable #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Jun 28, 2023
|
Looks Good, If you would like to add a small section on this in INSTALL.md, else can be covered in separate PR. |
lalitb
reviewed
Jun 28, 2023
| # current project binary output directory. | ||
| add_subdirectory(${OPENTELEMETRY_EXTERNAL_COMPONENT_PATH} | ||
| ${PROJECT_BINARY_DIR}/external) | ||
| elseif(DEFINED ENV{OPENTELEMETRY_EXTERNAL_COMPONENT_PATH}) |
There was a problem hiding this comment.
thanks for fixing this, seems I messed up this while changing the variable names as one of the comments.
marcalff
approved these changes
Jun 29, 2023
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2206
Changes
Fix the environment variable check, and also check if the same name (OPENTELEMETRY_EXTERNAL_COMPONENT_PATH) is defined as CMake variable. I'd prefer the cmake variable as it shows in the command line and help troubleshoot and create reproducible build, and env var is also taking effect in session global scope while CMake var is only for the CMake instance which is more restricted in scope.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes