Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Include nostd/string_view which is used severity.h #2219

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

ThomsonTan
Copy link
Contributor

Changes

Please provide a brief description of the changes here.

nostd::string_view is used in severity.h, but the header file is not included which then require the user to include it. This PR add "nostd/string_view.h" to include explicitly.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team July 6, 2023 16:36
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #2219 (0f51d43) into main (5466c5b) will not change coverage.
The diff coverage is n/a.

❗ Current head 0f51d43 differs from pull request most recent head c0a7feb. Consider uploading reports for the commit c0a7feb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files         169      169           
  Lines        4889     4889           
=======================================
  Hits         4279     4279           
  Misses        610      610           

@marcalff marcalff merged commit d6cebe1 into main Jul 7, 2023
@marcalff marcalff deleted the add_string_view_header branch July 7, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants