Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Allow metric instrument names to contain / characters #2310

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

marcalff
Copy link
Member

Fixes #2303

Changes

Allow / in metric instrument names.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team September 14, 2023 10:00
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2310 (70f8524) into main (f5f3934) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   87.53%   87.52%   -0.01%     
==========================================
  Files         199      199              
  Lines        5981     5981              
==========================================
- Hits         5235     5234       -1     
- Misses        746      747       +1     
Files Changed Coverage
sdk/src/metrics/instrument_metadata_validator.cc ø

@marcalff marcalff merged commit 44096c8 into open-telemetry:main Sep 14, 2023
45 checks passed
@marcalff marcalff deleted the fix_metric_name_slash_2303 branch October 27, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Allow metric instrument names to contain / characters
2 participants