Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMOVAL] Remove option WITH_OTLP_HTTP_SSL_PREVIEW #2435

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 6, 2023

Fixes #2383

Changes

CMake options WITH_OTLP_HTTP_SSL_PREVIEW
and WITH_OTLP_HTTP_SSL_TLS_PREVIEW are removed.
Building opentelemetry-cpp without SSL support is no longer possible.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team December 6, 2023 21:04
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2435 (93d0e5c) into main (0b9371d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6087     6087           
=======================================
  Hits         5299     5299           
  Misses        788      788           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@marcalff marcalff merged commit 51c2ee5 into open-telemetry:main Dec 13, 2023
45 checks passed
@marcalff marcalff deleted the fix_ssl_preview_2383 branch June 3, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REMOVAL] Remove option WITH_OTLP_HTTP_SSL_PREVIEW
3 participants