Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fixes CI markdown error MD055 - Table pipe style #2517

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

marcalff
Copy link
Member

Fixes # (issue)

Changes

Fixes build break in CI related to table formats with pipe.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team January 29, 2024 22:21
@marcalff
Copy link
Member Author

Somehow the CI build broke, complaining about tables formats in md, even without code change.

Possibly related to a newer version of markdown lint, did not checked.

Fixed the table format to be more explicit and easier to parse.

@marcalff marcalff added the pr:please-review This PR is ready for review label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cc781e) 87.12% compared to head (4296c94) 87.12%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2517   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         200      200           
  Lines        6109     6109           
=======================================
  Hits         5322     5322           
  Misses        787      787           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@marcalff marcalff merged commit 732f0b2 into open-telemetry:main Jan 29, 2024
48 checks passed
@marcalff marcalff deleted the fix_ci_markdown branch June 3, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants