Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Bump CMake minimum required version to 3.9 #2581

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Mar 7, 2024

Fixes #1399

Also resolves the following deprecation warnings:

Starting with CMake 3.27, support for CMake < 3.5 is deprecated.

Changed in version 3.27: Compatibility with versions of CMake older than 3.5 is deprecated.

For some platforms, CI logs for opentelemetry-cpp now shows:

CMake Deprecation Warning at CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

Changes

Please provide a brief description of the changes here.

  • Bump cmake_minimum_required to 3.9
    • at least 3.5 is required to clear the deprecation warning
    • at least 3.9 is required because gtest is used, the previous requirement of 3.1 was incorrect.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team March 7, 2024 21:57
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@marcalff marcalff merged commit 3e4b7d3 into open-telemetry:main Mar 8, 2024
47 checks passed
@marcalff marcalff deleted the fix_cmake_version branch June 3, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

”cmake_minimum_required(VERSION 3.1)“ is inaccurate
4 participants