[Code health] include-what-you-use cleanup #2692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2054
Changes
Performed general cleanup to resolve issues reported by
include-what-you-use
:For the most part, applying the code suggestions from
include-what-you-use
was sufficient.In some cases, in particular for:
the namespace directive causes
iwyu
to want a header to declare thenostd
namespace itself.Because there are many available headers, iwyu does not suggest the best choice.
Resolved by removing the namespace alias, and use fully qualified names instead:
Note that further cleanup is required, for code build optionally (various exporters, unit tests, etc).
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes