Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove benchmark overlay for vcpkg #2695

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ThomsonTan
Copy link
Contributor

There is no much special config in the local vcpkg overlay of benchmark. Remove it for now and use the from the the current vcpkg.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (0f2d4a7).
Report is 74 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      721      -66     

see 74 files with indirect coverage changes

@ThomsonTan ThomsonTan marked this pull request as ready for review June 6, 2024 05:12
@ThomsonTan ThomsonTan requested a review from a team June 6, 2024 05:12
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit bf8fa53 into open-telemetry:main Jun 6, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants